fix: handle disableAnimateOnMount prop for web ProgressCircle #280
+97
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
✅ Heimdall Review Status
✅
|
| Code Owner | Status | Calculation | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
| ui-systems-eng-team |
✅
2/1
|
Denominator calculation
|
bpk9
changed the title
Contributor
Author
|
If aligned, we should consider a similar fix for mobile |
hcopp
reviewed
Jan 1, 2026
| }: ProgressTextLabelProps) => { | ||
| const { getPreviousValue, addPreviousValue } = usePreviousValues<number>([ | ||
| disableAnimateOnMount ? value : 0, | ||
| ]); |
Contributor
There was a problem hiding this comment.
Code changes look great, thanks for catching this and for contributing
Can you run yarn bump-version and yarn release and then push the changes made by the scripts? You can ignore the jira question, and see here if you have any questions.
Contributor
Author
There was a problem hiding this comment.
Thanks Hunter, I ran the scripts and updated the PR 👍
hcopp
approved these changes
Jan 5, 2026
stacysun-cb
approved these changes
Jan 5, 2026
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
disableAnimateOnMountprop on the webProgressCirclecomponent.Root cause (required for bugfixes)
disableAnimateOnMountprop was not implemented on the webProgressCirclecomponent.UI changes
Before.mov
After.mov
Testing
How has it been tested?
Testing instructions
yarn nx run storybook:startChange management
type=routine
risk=low
impact=sev5
automerge=false